Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix present in results admin controller #4272

Merged
merged 7 commits into from Oct 15, 2018

Conversation

isaacmg410
Copy link
Contributor

@isaacmg410 isaacmg410 commented Oct 11, 2018

馃帺 What? Why?

This PR fix the issue when editing result, when proposal is related

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Change include to helper

馃摲 Screenshots (optional)

Description

@mrcasals
Copy link
Contributor

@isaacmg410 this PR closes @mijailr's #4268, right?

@isaacmg410
Copy link
Contributor Author

@mrcasals as I said, in #4267, we need to present the title of the proposals, to show correctly the hashtags on proposal title! The PR #4268 is not correct...

@mijailr
Copy link
Contributor

mijailr commented Oct 11, 2018

I already try that, this will fail

@mijailr
Copy link
Contributor

mijailr commented Oct 11, 2018

please close #4268, and restart the tests. This works now.

@mijailr
Copy link
Contributor

mijailr commented Oct 12, 2018

We have some decidim instances in production affected by this bug, could you please fix this?

@mrcasals
Copy link
Contributor

@mijailr we'll try to release a patch version with some other patches. Anyway, once this is merged you can modify your apps Gemfiles to point to this branch if needed.

@isaacmg410 could you please backport this to 0.14-stable once merged? Thanks! 馃槃

@isaacmg410
Copy link
Contributor Author

@mrcasals Sure! I will do it when the merge has been made

@mrcasals
Copy link
Contributor

@isaacmg410 some conflicts have arisen in the CHANGELOG, can you fix them??

@isaacmg410
Copy link
Contributor Author

@mrcasals fixed again... 馃槂

@mijailr
Copy link
Contributor

mijailr commented Oct 15, 2018

should this PR be backported to 0.14?

@mrcasals mrcasals merged commit d9dbe3d into master Oct 15, 2018
@mrcasals mrcasals deleted the fix_present_on_results_controller branch October 15, 2018 09:11
@mrcasals
Copy link
Contributor

@mijailr yes, it will!

@isaacmg410
Copy link
Contributor Author

@mrcasals @mijailr backported done, #4278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error editing result in accountability
3 participants