Consider components without admin engine on edit links #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mrcasals
force-pushed
the
fix/consider-unmanageable-components
branch
from
fdc54e2
to
b8f57de
Compare
mrcasals
force-pushed
the
fix/consider-unmanageable-components
branch
from
b8f57de
to
93bb4b4
Compare
oriolgual
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Some PRs ago we added a way to access the admin page for a given resource, from the public area. But we assumed all components had an admin engine to handle them. This assumption was wrong, see
decidim-datavizin Decidim Barcelona.This PR takes into account this case.
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry