add parent when duplicating assembly #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrcasals
reviewed
Oct 25, 2018
| @@ -50,6 +50,7 @@ def copy_assembly | |||
| banner_image: @assembly.banner_image, | |||
| promoted: @assembly.promoted, | |||
| scope: @assembly.scope, | |||
| parent: @assembly.parent, | |||
There was a problem hiding this comment.
Maybe add tests for this?
isaacmg410
force-pushed
the
fix_duplicate_children_as_mother
branch
from
3d8587a
to
ec2a711
Compare
mrcasals
previously approved these changes
Oct 25, 2018
|
@isaacmg410 There are some lint errors! |
isaacmg410
force-pushed
the
fix_duplicate_children_as_mother
branch
from
ec2a711
to
b614c06
Compare
|
@mrcasals now all is green 馃槃 |
mrcasals
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
When duplicate a children assembly it doesn't display in children assemblies backoffice. It's like you duplicate a mother assembly.
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry馃摲 Screenshots (optional)