Fix events for polymorphic authors #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Are you sure about this? This calls for a What do you think? |
|
@josepjaume the problem is not who is receiving the notification, the problem is that the notification text expects an author with a nickname and a profile and an organization doesn't have one. |
|
Oh, sorry! I totally misunderstood it! |
josepjaume
previously approved these changes
Oct 29, 2018
oriolgual
force-pushed
the
fix/polymorphic-author-fixes
branch
from
b95b5ae
to
c29b3cc
Compare
josepjaume
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Fix notification events went the author is not a user, they should behave like how it behaved previously with entities without author.
Needs to be backported to
0.15.馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry