Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment activity cell #4413

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix comment activity cell #4413

merged 2 commits into from
Oct 31, 2018

Conversation

oriolgual
Copy link
Contributor

@oriolgual oriolgual commented Oct 31, 2018 •
edited

馃帺 What? Why?

We were using commentable instead of root_commentable so the cell crashed when we tried to display an activity that was a comment on a comment.

Needs to be backported to 0.15.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

@ghost ghost assigned oriolgual Oct 31, 2018
@ghost ghost added the status: WIP label Oct 31, 2018
@oriolgual oriolgual mentioned this pull request Oct 31, 2018
Merged
@oriolgual oriolgual merged commit a9c71ce into master Oct 31, 2018
@oriolgual oriolgual deleted the fix-comment-activity-cell branch October 31, 2018 11:43
@oriolgual oriolgual added this to the CDP4 milestone Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josepjaume josepjaume josepjaume approved these changes

Assignees

@oriolgual oriolgual

Labels
in-review
Projects
None yet
Milestone
CDP4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oriolgual @josepjaume