Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contextual help improvements #4516

Merged
merged 16 commits into from
Nov 21, 2018
Merged

Contextual help improvements #4516

merged 16 commits into from
Nov 21, 2018

Conversation

josepjaume
Copy link
Contributor

@josepjaume josepjaume commented Nov 19, 2018 •
edited

🎩 What? Why?

This implements some improvements to contextual help:

  • Fixes welcome notification email and notification content
  • Adds floating help in each space's home
  • Opens the contextual help on initial render. Stores the help state on localStorage when closed.
  • Adds weight and show_in_footer properties in page topics.

📌 Related Issues

📋 Subtasks

None

📷 Screenshots (optional)

None

@ghost ghost assigned josepjaume Nov 19, 2018
@ghost ghost added the status: WIP label Nov 19, 2018
oriolgual
oriolgual previously approved these changes Nov 20, 2018
View reviewed changes
@mrcasals mrcasals merged commit adb35c4 into master Nov 21, 2018
@ghost ghost removed the status: WIP label Nov 21, 2018
@mrcasals mrcasals deleted the contextual_help_improvements branch November 21, 2018 11:23
@josepjaume josepjaume added this to the CDP5 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

@oriolgual oriolgual oriolgual left review comments

Assignees

@josepjaume josepjaume

Labels
None yet
Projects
None yet
Milestone
CDP5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josepjaume @oriolgual @mrcasals