Differentiate followers from affected users on sending events #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrcasals
force-pushed
the
notifications/differentiate-followers-and-relevant-users
branch
2 times, most recently
from
5175936
to
82bb029
Compare
oriolgual
reviewed
Dec 13, 2018
mrcasals
force-pushed
the
notifications/differentiate-followers-and-relevant-users
branch
6 times, most recently
from
e002d9e
to
d3dd1da
Compare
mrcasals
changed the title
|
Maybe I missed it, but shouldn't the notification message be different for followers and affected users? Maybe something like "you received this message because you're following" (followers) and "you've received this message because it's relevant to your activity" (affected users)? |
oriolgual
previously approved these changes
Dec 17, 2018
mrcasals
force-pushed
the
notifications/differentiate-followers-and-relevant-users
branch
from
9b87cf8
to
2017536
Compare
mrcasals
force-pushed
the
notifications/differentiate-followers-and-relevant-users
branch
from
4984f71
to
dabe4e0
Compare
oriolgual
previously approved these changes
Dec 17, 2018
oriolgual
approved these changes
Dec 17, 2018
oriolgual
deleted the
notifications/differentiate-followers-and-relevant-users
branch
|
This PR also closed #4640. |
This was referenced Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements part of #4439 by letting users choose what type of notifications they want to receive.
📌 Related Issues
📋 Subtasks
CHANGELOGentryActiveSupport::Notification(inEventsManager), publish both array of objects instead of a single array of user IDs📷 Screenshots (optional)