Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4656 document number verification #4794

Merged
merged 6 commits into from Jan 31, 2019
Merged

4656 document number verification #4794

merged 6 commits into from Jan 31, 2019

Conversation

entantoencuanto
Copy link
Contributor

@entantoencuanto entantoencuanto commented Jan 25, 2019 •
edited

馃帺 What? Why?

  • Adds a document_number_authorization_handler attribute to initiatives types to set an authorization handler to check if the document number provided in personal information of signatures is verified for the user.
  • Adds management of this attribute in the admin panel. The options for this field are taken from the available authorizations of the organization. The authorization handler must accept a document_number attribute and use a unique_id to perform verification.
  • A hash_id is generated on signatures including the document number to avoid initiatives signatures with the same document number.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

@ghost ghost assigned entantoencuanto Jan 25, 2019
@ghost ghost added the status: WIP label Jan 25, 2019
@entantoencuanto entantoencuanto force-pushed the 4656-document_number_verification branch from 7795504 to 5cd7666 Compare January 27, 2019 20:45
@ghost ghost added the status: WIP label Jan 28, 2019
@oriolgual
Copy link
Contributor

Could you please rebase this against master? I've merged some of the other PRs and there are some conflicts.

@entantoencuanto entantoencuanto force-pushed the 4656-document_number_verification branch from e9dd40d to e33d301 Compare January 28, 2019 14:49
@ghost ghost added the status: WIP label Jan 28, 2019
@entantoencuanto entantoencuanto force-pushed the 4656-document_number_verification branch from e33d301 to 380a829 Compare January 29, 2019 15:18
@ghost ghost added the status: WIP label Jan 29, 2019
@oriolgual
Copy link
Contributor

Sorry @entantoencuanto, could you please rebase this against master?

@entantoencuanto entantoencuanto force-pushed the 4656-document_number_verification branch from 380a829 to 830dab1 Compare January 31, 2019 10:29
@ghost ghost added the status: WIP label Jan 31, 2019
@entantoencuanto
Copy link
Contributor Author

Sorry @entantoencuanto, could you please rebase this against master?

Done!

@oriolgual oriolgual merged commit ca09b3b into master Jan 31, 2019
@oriolgual oriolgual deleted the 4656-document_number_verification branch January 31, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oriolgual oriolgual oriolgual approved these changes

Assignees

@entantoencuanto entantoencuanto

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@entantoencuanto @oriolgual