New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix amendments form: error messages and hashtags #4951
Merged
mrcasals
merged 24 commits into
decidim:master
from
aitorlb:fix/amendment_form_doesnt_show_errors
Apr 2, 2019
Merged
Fix amendments form: error messages and hashtags #4951
mrcasals
merged 24 commits into
decidim:master
from
aitorlb:fix/amendment_form_doesnt_show_errors
Apr 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor amendable module, forms, and views
aitorlb
changed the title
Fix amendments form show errors & hashtags
Fix amendments form: error messages and hashtags
Mar 22, 2019
mrcasals
suggested changes
Mar 25, 2019
mrcasals
previously approved these changes
Apr 2, 2019
mrcasals
approved these changes
Apr 2, 2019
馃憦 馃憦 |
armandfardeau
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
May 6, 2019
9 tasks
armandfardeau
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR fixes the following problems with amendments form:
馃搵 Subtasks
CHANGELOG
entry馃摲 Screenshots (optional)
Error messages BEFORE
Error messages AFTER
Hashtags BEFORE
Hashtags AFTER