Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amendments form: error messages and hashtags #4951

Merged

Conversation

aitorlb
Copy link
Contributor

@aitorlb aitorlb commented Mar 10, 2019

馃帺 What? Why?

This PR fixes the following problems with amendments form:

  • Doesn't show field error messages.
  • Doesn't display hashtags correctly.

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

馃摲 Screenshots (optional)

Error messages BEFORE

errors_before

Error messages AFTER

errors_after

Hashtags BEFORE

hashtags_before

Hashtags AFTER

hashtags_after

@aitorlb aitorlb reopened this Mar 22, 2019
@aitorlb aitorlb changed the title Fix amendments form show errors & hashtags Fix amendments form: error messages and hashtags Mar 22, 2019
@aitorlb aitorlb marked this pull request as ready for review March 24, 2019 18:18
@aitorlb aitorlb requested a review from mrcasals March 30, 2019 15:40
mrcasals
mrcasals previously approved these changes Apr 2, 2019
@mrcasals mrcasals merged commit f2f3be0 into decidim:master Apr 2, 2019
@tramuntanal
Copy link
Contributor

馃憦 馃憦

armandfardeau added a commit to OpenSourcePolitics/decidim that referenced this pull request May 6, 2019
armandfardeau added a commit to OpenSourcePolitics/decidim that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants