Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show a second reply button when comment is hidden #5045

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Don't show a second reply button when comment is hidden #5045

merged 3 commits into from
Apr 10, 2019

Conversation

armandfardeau
Copy link
Contributor

@armandfardeau armandfardeau commented Apr 3, 2019

馃帺 What? Why?

An additional reply was displayed on comments when a comment has been moderated. This leads to two replies button when a comment is masked. This can be disturbing for the user.

Excuse the night theme. This is obviously only present on my side.

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

馃摲 Screenshots (optional)

Before:
Capture d鈥檈虂cran 2019-04-02 a虁 20 56 07
Capture d鈥檈虂cran 2019-04-02 a虁 20 56 38

After:
Capture d鈥檈虂cran 2019-04-02 a虁 21 01 17

@armandfardeau armandfardeau marked this pull request as ready for review April 3, 2019 08:28
mrcasals
mrcasals previously approved these changes Apr 3, 2019
Copy link
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@oriolgual oriolgual requested a review from a team as a code owner April 10, 2019 09:59
@oriolgual oriolgual merged commit 64cd815 into decidim:master Apr 10, 2019
@armandfardeau armandfardeau deleted the fix/comments branch April 11, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants