New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proposal participants metrics #5048
Fix proposal participants metrics #5048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good to me, but maybe @MarcReniu would better confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can wait for @MarcReniu's approval if you want, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good for me! I should add a little comment in docs to take into account future modifications about who can create Proposals
@aitorlb can you check @MarcReniu's comment? |
Sorry, I didn't see it. Where should this comment go? And what should it say? Any help? |
Since this is fixing an important bug, I'll merge this and please add the docs that @MarcReniu suggested in another PR @aitorlb |
@aitorlb we would also need a migration or instructions in the changelog to recalculate the metrics that are wrong. |
@oriolgual the migration is for the future PR, right? |
Yup |
* Fix participants metrics * Add CHANGELOG entry
@oriolgual , @mrcasals , I'm seeing that metrics that are older than two month old don't get rendered in the visualizations. So, should the task to recalculate past metrics fix all existing metrics or only those that are two month old or less? |
I guess it's enough with the past two months |
馃帺 What? Why?
Changed query to take into account:
Decidim::UserBaseEntity
(proposal from users and user groups)Decidim::Organization
(official proposals)Decidim::Meetings::Meeting
(proposals that come from a meeting)Changed
馃搶 Related Issues
馃搵 Subtasks
CHANGELOG
entry