Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposal participants metrics #5048

Merged
merged 3 commits into from Apr 15, 2019

Conversation

aitorlb
Copy link
Contributor

@aitorlb aitorlb commented Apr 3, 2019

馃帺 What? Why?

Currently, if a proposal is official (the proposal is from the organization and not from a user), the participants that support the official proposal are not considered as participants in the participants metrics.

Changed query to take into account:

  • Decidim::UserBaseEntity (proposal from users and user groups)
  • Decidim::Organization (official proposals)
  • Decidim::Meetings::Meeting (proposals that come from a meeting)

Changed

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry

@aitorlb aitorlb changed the title Fix participants metrics Fix proposal participants metrics Apr 3, 2019
Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me, but maybe @MarcReniu would better confirm?

mrcasals
mrcasals previously approved these changes Apr 4, 2019
Copy link
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can wait for @MarcReniu's approval if you want, though.

MarcReniu
MarcReniu previously approved these changes Apr 4, 2019
Copy link
Contributor

@MarcReniu MarcReniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good for me! I should add a little comment in docs to take into account future modifications about who can create Proposals

@mrcasals
Copy link
Contributor

@aitorlb can you check @MarcReniu's comment?

@aitorlb
Copy link
Contributor Author

aitorlb commented Apr 12, 2019

Sorry, I didn't see it.

Where should this comment go? And what should it say? Any help?
@tramuntanal @mrcasals @MarcReniu

@oriolgual
Copy link
Contributor

Since this is fixing an important bug, I'll merge this and please add the docs that @MarcReniu suggested in another PR @aitorlb

@oriolgual oriolgual dismissed stale reviews from MarcReniu and mrcasals via 9df64ed April 15, 2019 10:58
@oriolgual oriolgual requested a review from a team as a code owner April 15, 2019 10:58
@oriolgual
Copy link
Contributor

@aitorlb we would also need a migration or instructions in the changelog to recalculate the metrics that are wrong.

@aitorlb
Copy link
Contributor Author

aitorlb commented Apr 15, 2019

@oriolgual the migration is for the future PR, right?

@oriolgual
Copy link
Contributor

@oriolgual the migration is for the future PR, right?

Yup

@oriolgual oriolgual merged commit 05ad6f0 into decidim:master Apr 15, 2019
microstudi added a commit to Platoniq/decidim that referenced this pull request Apr 18, 2019
* Fix participants metrics

* Add CHANGELOG entry
@aitorlb
Copy link
Contributor Author

aitorlb commented Apr 29, 2019

@oriolgual , @mrcasals , I'm seeing that metrics that are older than two month old don't get rendered in the visualizations. So, should the task to recalculate past metrics fix all existing metrics or only those that are two month old or less?

@oriolgual
Copy link
Contributor

I guess it's enough with the past two months

@tramuntanal tramuntanal deleted the fix/participants_metrics branch February 19, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats for processes: Participants
5 participants