-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user experience related to Consultations/Questions #5112
Merged
oriolgual
merged 10 commits into
decidim:master
from
CodiTramuntana:feat/consultations-questions-buttons
May 23, 2019
Merged
Improve user experience related to Consultations/Questions #5112
oriolgual
merged 10 commits into
decidim:master
from
CodiTramuntana:feat/consultations-questions-buttons
May 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@oriolgual the test that failed on CircleCI passes on my local machine |
Could you please retry the job that failed? |
@oriolgual this test kept on failing until I merged Randomized with seed 23216
F
...
Shared Example Group: "searchable results" called from ./spec/system/search_proposals_spec.rb:15 Image screenshot of the failure. |
oriolgual
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Consultation
page depending on whether the user has voted it or notQuestion
page📌 Related Issues
📋 Subtasks
CHANGELOG
entry📷 Screenshots (optional)
Consultation page
Question page
Question page (small view)