Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience related to Consultations/Questions #5112

Merged

Conversation

aitorlb
Copy link
Contributor

@aitorlb aitorlb commented May 3, 2019

🎩 What? Why?

  • Change button appearance when listing questions in the Consultation page depending on whether the user has voted it or not
  • Add previous/next button when viewing the Question page

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

Consultation page

Chapa  Varela y Collazo Asociados

Question page

Unde itaque aliquid    Chapa  Varela y Collazo Asociados

Question page (small view)

Unde itaque aliquid    Chapa  Varela y Collazo Asociados (1)

@aitorlb aitorlb requested a review from a team as a code owner May 3, 2019 10:18
@aitorlb
Copy link
Contributor Author

aitorlb commented May 7, 2019

@oriolgual the test that failed on CircleCI passes on my local machine

@oriolgual
Copy link
Contributor

oriolgual commented May 7, 2019

Could you please retry the job that failed?

@aitorlb
Copy link
Contributor Author

aitorlb commented May 10, 2019

@oriolgual this test kept on failing until I merged master into my branch:

Randomized with seed 23216
F
...
Shared Example Group: "searchable results" called from ./spec/system/search_proposals_spec.rb:15

Image screenshot of the failure.

@oriolgual oriolgual merged commit 3ea115a into decidim:master May 23, 2019
@tramuntanal tramuntanal deleted the feat/consultations-questions-buttons branch February 19, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants