Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience related to Consultations/Questions #5112

Merged

Conversation

Projects
None yet
2 participants
@aitorlb
Copy link
Contributor

commented May 3, 2019

馃帺 What? Why?

  • Change button appearance when listing questions in the Consultation page depending on whether the user has voted it or not
  • Add previous/next button when viewing the Question page

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

馃摲 Screenshots (optional)

Consultation page

Chapa  Varela y Collazo Asociados

Question page

Unde itaque aliquid    Chapa  Varela y Collazo Asociados

Question page (small view)

Unde itaque aliquid    Chapa  Varela y Collazo Asociados (1)

@aitorlb aitorlb requested a review from decidim/lot-core as a code owner May 3, 2019

aitorlb added some commits May 3, 2019

@aitorlb

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@oriolgual the test that failed on CircleCI passes on my local machine

@oriolgual

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Could you please retry the job that failed?

@aitorlb

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@oriolgual this test kept on failing until I merged master into my branch:

Randomized with seed 23216
F
...
Shared Example Group: "searchable results" called from ./spec/system/search_proposals_spec.rb:15

Image screenshot of the failure.

aitorlb and others added some commits May 14, 2019

@oriolgual oriolgual merged commit 3ea115a into decidim:master May 23, 2019

0 of 3 checks passed

ci/circleci: build_test_app Your tests are queued behind your running builds
Details
ci/circleci: main Your tests are queued behind your running builds
Details
codeclimate Code Climate is analyzing this code.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.