Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consultation results #5188

Merged
merged 9 commits into from Jun 17, 2019
Merged

Conversation

microstudi
Copy link
Contributor

馃帺 What? Why?

Adds a results page in the admin of consultations.
It show the number of votes per question (but not the responses) if the consultation is active.
It show all the results per question, with all the responses results if the consultation has finished.

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

馃摲 Screenshots (optional)

failures_r_spec_example_groups_admin_manages_results_viewing_votes_without_results_shows_votes_only_433
failures_r_spec_example_groups_admin_manages_results_viewing_finished_consultations_with_votes_show_votes_total_760

@microstudi microstudi requested a review from a team as a code owner June 10, 2019 16:38
@oriolgual
Copy link
Contributor

Is this related to something at metadecidim or approved by @decidim/product, @microstudi?

Copy link
Contributor

@oriolgual oriolgual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes related to non English locales. All locales files are handled by Crowdin and modifying them directly would cause conflicts.

@microstudi
Copy link
Contributor Author

Is this related to something at metadecidim or approved by @decidim/product, @microstudi?

Yes, approved today:
https://meta.decidim.org/processes/roadmap/f/122/proposals/14630

@microstudi
Copy link
Contributor Author

@oriolgual should be fixed, sorry about the locales, I inadvertently made a mess with them when using the i18n normalizer.

I've added the total_votes method to the Consultation model, but it only counts the votes for the published questions. It makes more sense to me, but let me know if you think otherwise.

oriolgual
oriolgual previously approved these changes Jun 17, 2019
@oriolgual oriolgual merged commit 7d2bb5b into decidim:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants