Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Additional sorting filters for proposals index #5506

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Add: Additional sorting filters for proposals index #5506

merged 2 commits into from
Nov 21, 2019

Conversation

aitorlb
Copy link
Contributor

@aitorlb aitorlb commented Nov 20, 2019 •
edited
Loading

馃帺 What? Why?

As a participant, I want to be able to sort proposals by

  • Random
  • Recent
  • Most suported
  • Most endorsed
  • Most commented
  • Most followed
  • With More authors

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

馃摲 Screenshots (optional)

Description

@aitorlb aitorlb force-pushed the add/proposals_sorting_filters branch from 6dab698 to 0cdd7b1 Compare November 20, 2019 16:18
@carolromero
Copy link
Member

Hi @aitorlb it works beautifully, I just found this detail in the displayed order
imatge

@aitorlb
Copy link
Contributor Author

aitorlb commented Nov 21, 2019 •
edited
Loading

@carolromero Yes, we deployed before I asked you and made the change. Sorry.

We'll redeploy and let you know.

@aitorlb aitorlb added the contract: AM2019 Barcelona City Council contract label Nov 21, 2019
@aitorlb aitorlb self-assigned this Nov 21, 2019
@aitorlb
Copy link
Contributor Author

aitorlb commented Nov 21, 2019

@carolromero you can check again the staging app

@carolromero
Copy link
Member

Tested! Thanks!

tramuntanal
tramuntanal reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@tramuntanal tramuntanal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions to make the code cleaner.

Also remember to add the changelog entry please :D

decidim-proposals/app/controllers/concerns/decidim/proposals/orderable.rb Show resolved Hide resolved
decidim-proposals/app/controllers/concerns/decidim/proposals/orderable.rb Show resolved Hide resolved
tramuntanal
tramuntanal approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm dismissing my comments as I didn't know that raw sql was being deprecated: https://blog.bigbinary.com/2018/10/16/rails-5-2-disallows-raw-sql-in-active-record.html

Approved!!

@tramuntanal tramuntanal merged commit 7e08484 into decidim:master Nov 21, 2019
@tramuntanal tramuntanal deleted the add/proposals_sorting_filters branch November 21, 2019 22:12
@tramuntanal
Copy link
Contributor

@aitorlb can you please open a PR for the changelog entry?

@aitorlb aitorlb mentioned this pull request Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tramuntanal tramuntanal tramuntanal approved these changes

Assignees

@aitorlb aitorlb

Labels
contract: AM2019 Barcelona City Council contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aitorlb @carolromero @tramuntanal