Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix ref on GitHub Actions checkout step #5954

Closed
wants to merge 5 commits into from

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Apr 10, 2020

馃帺 What? Why?

We've noticed more funky issues with coverage reports. More precisely, the issue seems to come from a bunch of factors, but let me try to explain the issue first.

How to reproduce
  1. Create a PR
  2. Make one of the workflows fail for random issues apart from RSpec. The best way to reprocue it is getting a random failure while trying to install the Ruby dependencies.
  3. Retry that workflow, see it passing successfully.
  4. Open the coverage reports. See that there's no reports for the files in the first-failed-then-successful workflow
  5. Open that workflow on GitHub Actions, open the coverage report step and see it failing.

To be fair, the step 2 should be fixed by #5910, but the real issue persists.

Reasons why it's failing

If you check the checkout step on a successful workflow, you'll see it's creating a special branch names pull/<PR id>/merge (replacing <PR id> with the correct number). This creates a new commit.

If you check the same step for a first-failed-then-successful workflow you'll see it's not using that werid branch name, but instead it's using the real branch name. This inconsistency makes the coverage report to fail, for some reason.

Checking the actions/checkout repository, I don't see any specific place where that weird branch name is specified, so this would only mean it comes from the GitHub Actions environment itself.

馃搶 Related Issues

  • Related to #?
  • Fixes #?

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

馃摲 Screenshots (optional)

Description

@mrcasals mrcasals changed the title [WIP] Print env on GitHub Actions workflows [WIP] Fix ref on GitHub Actions checkout step Apr 10, 2020
@mrcasals mrcasals force-pushed the chore/fix-pr-coverage-issues branch from 4c48312 to 3ac6c31 Compare April 10, 2020 12:00
@mrcasals
Copy link
Contributor Author

Closing in favor of #5991

@mrcasals mrcasals closed this Apr 17, 2020
@andreslucena andreslucena deleted the chore/fix-pr-coverage-issues branch September 28, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant