Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark meetings spec as slow #6595

Merged
merged 1 commit into from Oct 6, 2020
Merged

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Oct 5, 2020

🎩 What? Why?

We're having a slow test on meetings that's failing most of the time. Until we find a better solution for it, this PR marks the test as slow so it doesn't fail.

📌 Related Issues

None

Testing

Let tests run, see no errors

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

None

♥️ Thank you!

@tramuntanal
Copy link
Contributor

Hi @mrcasals ,

We've already tried this in a local environment and it did not work.
I'm going to re-run the meetings workflow some times in order to see if it always succeed in the CI.

@tramuntanal
Copy link
Contributor

It succeeded at the second attempt

@tramuntanal tramuntanal self-assigned this Oct 6, 2020
@tramuntanal
Copy link
Contributor

It succeeded at the third attempt, it seems it solves the issue in the CI
Trying one last time

@mrcasals
Copy link
Contributor Author

mrcasals commented Oct 6, 2020

@tramuntanal this succeeded again! Can we merge this so that all other PRs can get fixed? 😄

@mrcasals mrcasals mentioned this pull request Oct 6, 2020
12 tasks
@tramuntanal
Copy link
Contributor

Yess, it is strange we couldn't reproduce it locally, maybe it was dues to a bad test_app.
Merging!

@tramuntanal tramuntanal merged commit 0e94774 into develop Oct 6, 2020
@tramuntanal tramuntanal deleted the allow-slower-test-meetings branch October 6, 2020 07:33
@tramuntanal
Copy link
Contributor

Anyway we're working on adding the spinner when ajax calls are executed

@mrcasals
Copy link
Contributor Author

mrcasals commented Oct 6, 2020

The spinner would be awesome indeed!

I wasn't able to reproduce it locally, which meant it was a problem with timeouts in requests. The :slow tag on tests allows for a longer timout, which "fixed" the problem.

@tramuntanal
Copy link
Contributor

do you run test with bundler?
bundle exec rspec ... or directly with rspec rspec ...

@Leusev Leusev mentioned this pull request Oct 6, 2020
1 task
roxanaopr pushed a commit to tremend-cofe/decidim that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants