Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nickname prefix wraps on certain view widths #6649

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix nickname prefix wraps on certain view widths #6649

merged 1 commit into from
Oct 13, 2020

Conversation

segoy89
Copy link
Contributor

@segoy89 segoy89 commented Oct 8, 2020

🎩 What? Why?

Fix for #6496 issue

📌 Related Issues

Testing

Visit http://localhost:3003/users/sign_up and observe that the nickname prefix is no longer in a separate line

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Screenshot 2020-10-08 at 13 52 19

♥️ Thank you!

@ivan-mr ivan-mr self-assigned this Oct 8, 2020
@ivan-mr ivan-mr self-requested a review October 8, 2020 22:07
@ivan-mr
Copy link
Contributor

ivan-mr commented Oct 8, 2020 •
edited
Loading

Hi @segoy89 and thanks for the fix, but can you also fix the 2 codeclimate issues, please?

@segoy89 segoy89 force-pushed the fix/nickname-prefix-wraps-on-certain-view-widths branch from 0a5d579 to a48dc46 Compare October 12, 2020 12:02
@segoy89
Copy link
Contributor Author

segoy89 commented Oct 12, 2020

Hi @segoy89 and thanks for the fix, but can you also fix the 2 codeclimate issues, please?

@ivan-mr codeclimate's complaints addressed. Sorry for the delay 😢

ivan-mr
ivan-mr approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @segoy89 !

@ivan-mr ivan-mr merged commit 24358b3 into decidim:develop Oct 13, 2020
@larsUE larsUE mentioned this pull request Jan 13, 2021
Closed
@mrcasals mrcasals added the type: fix PRs that implement a fix for a bug label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-mr ivan-mr ivan-mr approved these changes

Assignees

@ivan-mr ivan-mr

Labels
in-review module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nickname prefix wraps on certain view widths
3 participants
@segoy89 @ivan-mr @mrcasals