Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pending authorizations as a list #6680

Merged
merged 1 commit into from Oct 15, 2020

Conversation

ovruni
Copy link
Contributor

@ovruni ovruni commented Oct 14, 2020

🎩 What? Why?

Currently the list of pending verifications is displayed in a single row, which makes it impossible to see the entire list with the width of the screen.
These changes show each pending verification in a different row.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

  1. Login as admin
  2. Enter the Admin dashboard
  3. Enter the section Participants -> Verifications -> Identity documents
  4. Here you can see the list in one row and the documents in each different column, which truncates the list

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Before
pending_authorization_list-00
After
pending_authorization_list-01

♥️ Thank you!

@tramuntanal
Copy link
Contributor

I'm re-running admin tests that hanged due to Net::ReadTimeout

@tramuntanal tramuntanal self-assigned this Oct 15, 2020
@tramuntanal
Copy link
Contributor

tramuntanal commented Oct 15, 2020

Thank you for your contribution Omar 😄
@decidim/product I find this refactor a good improvement, can you confirm please?

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems like a bug, thanks!

@andreslucena andreslucena removed the request for review from carolromero October 15, 2020 07:39
@tramuntanal tramuntanal merged commit fad520b into decidim:develop Oct 15, 2020
@tramuntanal
Copy link
Contributor

Thank you very much for this PR, I think it is the first one to Decidim, welcome @ovruni ! 😄

tramuntanal pushed a commit that referenced this pull request Oct 15, 2020
tramuntanal pushed a commit that referenced this pull request Oct 15, 2020
tramuntanal added a commit that referenced this pull request Oct 16, 2020
Co-authored-by: Omar Vega Ramos <ovruni@riseup.net>
@mrcasals mrcasals added module: verifications type: change PRs that implement a change for an existing feature labels Feb 26, 2021
@mrcasals mrcasals changed the title Fix pending authorization list Show pending authorizations as a list Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review module: verifications type: change PRs that implement a change for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants