Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix elections count in Homepage statistics" to 0.23 #6686

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Backport "Fix elections count in Homepage statistics" to 0.23 #6686

merged 1 commit into from
Oct 15, 2020

Conversation

tramuntanal
Copy link
Contributor

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@tramuntanal tramuntanal changed the base branch from develop to release/0.23-stable October 15, 2020 09:45
@Leusev Leusev self-requested a review October 15, 2020 09:57
Leusev
Leusev approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tramuntanal

@tramuntanal tramuntanal merged commit 6119472 into release/0.23-stable Oct 15, 2020
@tramuntanal tramuntanal deleted the backport/fix/home-statistics-elections_count branch October 15, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-mr ivan-mr ivan-mr approved these changes

@Leusev Leusev Leusev approved these changes

Assignees
No one assigned
Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tramuntanal @ivan-mr @Leusev @andreslucena