Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users close meetings from public pages #6703

Merged

Conversation

mrcasals
Copy link
Contributor

馃帺 What? Why?

Let users close meetings from public pages.

馃搶 Related Issues

Testing

Meeting organisers can close the meeting from the public page. When doing that, they can add a closing report and link proposals.

Screenshots

Screen Shot 2020-10-14 at 11 38 47
Screen Shot 2020-10-14 at 11 39 36

鈾ワ笍 Thank you!

@mrcasals
Copy link
Contributor Author

@decidim/product this PR implements https://meta.decidim.org/processes/roadmap/f/122/proposals/15625, can you check it out please?

Here's the Review App:

https://decidim-staging-pr-206.herokuapp.com/

@carolromero
Copy link
Member

@mrcasals I reviewed this, works great, as usual 馃槑
Just a couple of comments on the design:

  • We should apply the primary color variable on the close button, as we already do with Debates.

imatge

  • I noticed that the style of the selected proposals is hard-coded, isn't it? I was going to tell you that we also use the primary variable but after doing some tests and foreseeing the length of the proposals titles and to improve the readability I propose to use this style:
.label.primary {
 background:#eee;
 color:#202734;
}

imatge

Finally, although it is not specified in Metadecidim's proposal, I think that when closing a meeting the edit button should disappear. Otherwise, you can edit closed meetings by changing the date to the future, for example:

imatge

@mrcasals
Copy link
Contributor Author

@carolromero thanks! In this case, work was done by @mllocs 馃槃

We'll take care of the changes you ask! 馃槃

@mrcasals
Copy link
Contributor Author

I've done the fixes:

Button fix to use the primary color:
image

Improve design of selected proposals:
image

Once the meeting is closed, it cannot be edited again:
image

@mrcasals
Copy link
Contributor Author

@carolromero I've updated the review app with the latest changes: https://decidim-staging-pr-206.herokuapp.com/

@carolromero
Copy link
Member

@mrcasals everything looking great now!

@mrcasals
Copy link
Contributor Author

Awesome, thanks!

@decidim/core can you review this, please? It has been approved by Product! 馃槃

@tramuntanal tramuntanal self-assigned this Oct 23, 2020
Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good here!
There are just some comments to be corrected, that's all 馃槃

end
end

describe "closing someone else's meeting" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good check!

Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
@mrcasals
Copy link
Contributor Author

@tramuntanal I've committed all suggested changes! 馃槃

@tramuntanal
Copy link
Contributor

@mrcasals Surveys / Tests were failing, I've re-run them just in case, but take a look at them please 馃檹

@tramuntanal tramuntanal merged commit 144dc20 into decidim:develop Oct 30, 2020
@mrcasals mrcasals deleted the feat/close-meeting-in-public-pages branch October 30, 2020 14:35
@mrcasals mrcasals added module: meetings type: feature PRs or issues that implement a new feature labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review module: meetings type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants