New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let users close meetings from public pages #6703
Let users close meetings from public pages #6703
Conversation
Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
@decidim/product this PR implements https://meta.decidim.org/processes/roadmap/f/122/proposals/15625, can you check it out please? Here's the Review App: |
@mrcasals I reviewed this, works great, as usual 馃槑
Finally, although it is not specified in Metadecidim's proposal, I think that when closing a meeting the edit button should disappear. Otherwise, you can edit closed meetings by changing the date to the future, for example: |
@carolromero thanks! In this case, work was done by @mllocs 馃槃 We'll take care of the changes you ask! 馃槃 |
@carolromero I've updated the review app with the latest changes: https://decidim-staging-pr-206.herokuapp.com/ |
@mrcasals everything looking great now! |
Awesome, thanks! @decidim/core can you review this, please? It has been approved by Product! 馃槃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good here!
There are just some comments to be corrected, that's all 馃槃
decidim-meetings/app/commands/decidim/meetings/close_meeting.rb
Outdated
Show resolved
Hide resolved
decidim-meetings/app/controllers/decidim/meetings/meeting_closes_controller.rb
Outdated
Show resolved
Hide resolved
decidim-meetings/app/forms/decidim/meetings/close_meeting_form.rb
Outdated
Show resolved
Hide resolved
end | ||
end | ||
|
||
describe "closing someone else's meeting" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good check!
Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
@tramuntanal I've committed all suggested changes! 馃槃 |
@mrcasals Surveys / Tests were failing, I've re-run them just in case, but take a look at them please 馃檹 |
馃帺 What? Why?
Let users close meetings from public pages.
馃搶 Related Issues
Testing
Meeting organisers can close the meeting from the public page. When doing that, they can add a closing report and link proposals.
Screenshots