Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit initiative as promoter #6790

Merged
merged 27 commits into from
Nov 18, 2020
Merged

Conversation

edgarlatorre
Copy link
Contributor

@edgarlatorre edgarlatorre commented Nov 3, 2020

🎩 What? Why?

Edit an initiative as a prometer in the public are.

  • Create actions edit and update
  • Create template for edit an initiative
  • Add permissions for edit and update an initiative
  • Allow upload multiple files
  • Print form application
  • Manage committee
  • Send technical validation

📌 Related Issues

Link your PR to an issue

Testing

Create an initiative as a promoter then you should be able to edit it in the public area.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

Please add screenshots of the changes you're proposing
image

image

image

image

image

image

♥️ Thank you!

@edgarlatorre edgarlatorre self-assigned this Nov 3, 2020
@edgarlatorre edgarlatorre marked this pull request as draft November 3, 2020 09:28
@edgarlatorre edgarlatorre marked this pull request as ready for review November 3, 2020 10:19
@edgarlatorre edgarlatorre linked an issue Nov 3, 2020 that may be closed by this pull request
11 tasks
@edgarlatorre edgarlatorre force-pushed the feature/edit-initiative-as-promoter branch from 0592729 to 27de5c4 Compare November 4, 2020 11:22
@edgarlatorre edgarlatorre force-pushed the feature/edit-initiative-as-promoter branch from 3fac363 to 3ea168f Compare November 4, 2020 17:13
@marinavega marinavega linked an issue Nov 9, 2020 that may be closed by this pull request
marinavega
marinavega previously approved these changes Nov 9, 2020
@edgarlatorre edgarlatorre force-pushed the feature/edit-initiative-as-promoter branch from 1a7584a to 4683955 Compare November 16, 2020 10:19
@edgarlatorre
Copy link
Contributor Author

@decidim/core This was approved by @decidim/product and can be reviewed whenever you have some time. Thanks!

Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has many files involved but was straightforward to check, thanks @edgarlatorre :D
LGTM!

@tramuntanal tramuntanal merged commit 717b631 into develop Nov 18, 2020
@tramuntanal tramuntanal deleted the feature/edit-initiative-as-promoter branch November 18, 2020 08:12
@edgarlatorre
Copy link
Contributor Author

Sorry for the PR having too many files, the epic got a bit bigger than expected. Thanks a lot!

@tramuntanal
Copy link
Contributor

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: initiatives type: feature PRs or issues that implement a new feature
Projects
None yet
4 participants