Add and use decidim-bulletin_board gem #6997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leio10
previously approved these changes
Dec 9, 2020
| @@ -66,6 +66,7 @@ def election_data | |||
| { | |||
| iat: Time.now.to_i, | |||
| election_id: election_id, | |||
| message_id: "#{election_id}.create_election+a.#{bulletin_board.authority_slug}", | |||
| type: "create_election", | |||
There was a problem hiding this comment.
we can remove the election_id and create_election, as they are included in the message_id
There was a problem hiding this comment.
Yeah, I have that in mind. I wanted to do that with the refactoring of moving the whole election_data to the gem.
slickepinne
dismissed stale reviews from leio10, agustibr, and beagleknight
via
ccf8a77
slickepinne
force-pushed
the
refactor/move-bulletin-board-client-to-bb-gem
branch
from
dec1d9d
to
ccf8a77
Compare
agustibr
previously approved these changes
Dec 9, 2020
|
@decidim/core Could you review this PR, please? 🙏 |
beagleknight
previously approved these changes
Dec 10, 2020
leio10
force-pushed
the
refactor/move-bulletin-board-client-to-bb-gem
branch
from
ccf8a77
to
d4d51ab
Compare
tramuntanal
deleted the
refactor/move-bulletin-board-client-to-bb-gem
branch
mrcasals
added
module: elections
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR refactors the election module. Since we have a
decidim-bulletin_boardgem now, we removed the bb client logic fromdecidim.Testing
The
decidim-bulletin_boardis a dependency for theelections module. If you setup an election for example, this new gem gets used. There's also a system and unit test.📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
