Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML from tooltips on "Visit URL" link #7032

Merged

Conversation

roxanaopr
Copy link
Contributor

🎩 What? Why?

On "Global Moderation" section from admin dashboard, the tool tip for "Visit URL" text contains tags.

📌 Related Issues

Bug opened on metadecidim: https://meta.decidim.org/processes/bug-report/f/210/proposals/15837
Screenshot from 2020-12-16 13-45-48

Testing

  1. Login as admin and go to Admin dashboard
  2. Create a meeting and report it from the interface
  3. Go to global moderation
  4. Check the tool tip.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

alecslupu and others added 20 commits October 13, 2020 10:12
Bump develop to next release version
@oliverbarnes
Copy link
Contributor

Hi @roxanaopr, this is looking good 👍 Would be great to have a test covering it as well, to avoid regressions in the future

@roxanaopr
Copy link
Contributor Author

Hi @oliverbarnes! The test has been added.

oliverbarnes
oliverbarnes previously approved these changes Dec 17, 2020
Copy link
Contributor

@oliverbarnes oliverbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thanks @roxanaopr and @alecslupu! cc @ivan-mr for merging

@tramuntanal tramuntanal self-assigned this Dec 29, 2020
Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @roxanaopr
Just one detail in the test so we're covered for regressions.

@tramuntanal tramuntanal merged commit 23b5be4 into decidim:develop Dec 29, 2020
@alecslupu alecslupu deleted the feature/global-moderation-tooltip-text branch January 20, 2021 10:18
@mrcasals mrcasals changed the title Tool tip text displayed with tags on "Visit URL" link Remove HTML from tooltips on "Visit URL" link Feb 26, 2021
@mrcasals mrcasals added module: admin type: fix PRs that implement a fix for a bug labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review module: admin type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants