Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proposals admin form when editing #7042

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Fix proposals admin form when editing #7042

merged 1 commit into from
Dec 21, 2020

Conversation

oriolgual
Copy link
Contributor

@oriolgual oriolgual commented Dec 17, 2020 •
edited
Loading

🎩 What? Why?

When editing an official proposal fromt he admin there was no title or body content in the input fields, this fixes it.

📌 Related Issues

Testing

Edit an official proposal from the admin, the title and body input should have the content of the proposal.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@mrcasals
Copy link
Contributor

@oriolgual there are some failing tests!

@mrcasals
Copy link
Contributor

Apart from tests, implementation looks good to me!

@microstudi
Copy link
Contributor

Note: this should be backported to 0.23

@microstudi microstudi mentioned this pull request Dec 18, 2020
Closed
@oriolgual oriolgual marked this pull request as ready for review December 18, 2020 15:45
@oriolgual
Copy link
Contributor Author

Ready for review @decidim/core

tramuntanal
tramuntanal approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@tramuntanal tramuntanal merged commit 4aeded5 into develop Dec 21, 2020
@tramuntanal tramuntanal deleted the fix/proposal-admin-form branch December 21, 2020 07:09
@tramuntanal
Copy link
Contributor

@oriolgual can you backport to v0.23?

@mrcasals
Copy link
Contributor

@tramuntanal I'll do that!

mrcasals pushed a commit that referenced this pull request Dec 21, 2020
@oriolgual @mrcasals
Fix proposals admin form when editing. Closes #7031 (#7042)
af598c1
@mrcasals mrcasals mentioned this pull request Dec 21, 2020
Merged
@mrcasals
Copy link
Contributor

@tramuntanal please, check #7051! 😄

tramuntanal pushed a commit that referenced this pull request Dec 24, 2020
@mrcasals @oriolgual
Fix proposals admin form when editing. Closes #7031 (#7042) (#7051)
a53a240 
Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
@mrcasals mrcasals added module: proposals type: fix PRs that implement a fix for a bug labels Feb 26, 2021
@oliverbarnes oliverbarnes mentioned this pull request Mar 16, 2021
Closed
@ahukkanen ahukkanen mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tramuntanal tramuntanal tramuntanal approved these changes

@mrcasals mrcasals Awaiting requested review from mrcasals

Assignees
No one assigned
Labels
module: proposals type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When editing official proposals, title and body appear blank
4 participants
@oriolgual @mrcasals @microstudi @tramuntanal