Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button texts on initiative finish page #7169

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

When making some initiatives docs, I found out that we could improve some of the buttons in the finish step of the wizard:

πŸ“Œ Related Issues

Testing

  1. Create an initiative
  2. See the finish step

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Before

imatge

After

imatge

β™₯️ Thank you!

@oriolgual oriolgual merged commit 9220b55 into develop Jan 18, 2021
@oriolgual oriolgual deleted the fix/initiative_finish branch January 18, 2021 14:39
@mrcasals mrcasals added module: initiatives type: change PRs that implement a change for an existing feature labels Feb 26, 2021
@mrcasals mrcasals changed the title Fix initiative finish actions Update button texts on initiative finish page Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: initiatives type: change PRs that implement a change for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants