-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include area in initiatives export #7242
Merged
mrcasals
merged 3 commits into
decidim:develop
from
liquidvotingio:feature/add-areas-to-initiatives-export
Feb 3, 2021
Merged
Include area in initiatives export #7242
mrcasals
merged 3 commits into
decidim:develop
from
liquidvotingio:feature/add-areas-to-initiatives-export
Feb 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandfardeau
approved these changes
Feb 3, 2021
mrcasals
reviewed
Feb 3, 2021
require "spec_helper" | ||
|
||
module Decidim::Initiatives | ||
describe InitiativeSerializer do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including so many tests! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pleasure! :)
mrcasals
approved these changes
Feb 3, 2021
armandfardeau
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Feb 4, 2021
armandfardeau
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Feb 8, 2021
* Backport decidim#7242 * Fix offenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Includes an initiative's area name to the serialized Initiative fields, to be included when exporting initiatives from the admin.
Also adds overall test coverage to the initiative serializer.
📌 Related Issues
Metadecidim issue: https://meta.decidim.org/processes/roadmap/f/122/proposals/16199
Testing
Go to https://decidim-staging.liquidvoting.io/ and log-in as admin@example.org / decidim123456
Then go to https://decidim-staging.liquidvoting.io/admin/initiatives and click on "Export", then "Initiatives as CSV":
You should see a confirmation message saying the email with the export was sent:
You can view the email and download the exported zip at: https://decidim-staging.liquidvoting.io/letter_opener
And a sample exported zip file here: https://decidim-staging.liquidvoting.io/letter_opener/1611949506_9309008_b5bc353/attachments/initiatives-2021-01-29-71106.zip
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots
Nothing changes visually, but here's a screenshot of where to test this: