Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS selectors to emails to improve design customization #7493

Merged

Conversation

verarojman
Copy link
Contributor

@verarojman verarojman commented Mar 2, 2021

🎩 What? Why?

This PR adds css classes to html elements in emails to improve their identification in the emails css stylesheet.

📌 Related Issues

I found none.

Testing

Customize decidim/email css using the selectors added in this PR.

PS:

Are there any design-related "checks" for maintainers to ensure PRs use the standard classes and they style elements complying with the design guidelines?

♥️ Thank you!

@mrcasals
Copy link
Contributor

mrcasals commented Mar 2, 2021

Are there any design-related "checks" for maintainers to ensure PRs use the standard classes and they style elements complying with the design guidelines?

I don't think so, no!

Regarding the PR itself, maybe it's better to create a new Newsletter template? That'd be more robust than just overwriting CSS, since using your own template would make sure nothing breaks...

@verarojman
Copy link
Contributor Author

verarojman commented Mar 2, 2021

Are there any design-related "checks" for maintainers to ensure PRs use the standard classes and they style elements complying with the design guidelines?

I don't think so, no!

Regarding the PR itself, maybe it's better to create a new Newsletter template? That'd be more robust than just overwriting CSS, since using your own template would make sure nothing breaks...

The thing is that, besides from the newsletter, there are over 30 email templates which can have "call-to-action" buttons that are currently displayed as plain links. I'm adding these classes to be able to style these emails without having to guess that a link inside an email will be a call to action button and should therefore be styled as such. (Because I just did and it didn't work well 🤯)

(And I would like to have a better solution than overriding 30 files to customize styles for a decidim instance hehehehe) 💓

@mrcasals
Copy link
Contributor

mrcasals commented Mar 2, 2021

Ah sorry, I thought it was only about newsletters, not plain emails. Thanks!

@mrcasals mrcasals merged commit 6512762 into decidim:develop Mar 2, 2021
@mrcasals mrcasals changed the title Add css selectors to emails to improve design customization Add CSS selectors to emails to improve design customization Mar 2, 2021
@verarojman
Copy link
Contributor Author

Thank you!

entantoencuanto added a commit that referenced this pull request Mar 2, 2021
* develop: (25 commits)
  Add css selectors to emails to improve design customization (#7493)
  Only share tokens if component exists (#7499)
  Fix record encryptor hash values JSON parsing for legacy unencrypted hash values (#7494)
  Fix NULL error with weight field in assemblies & processes (#7486)
  Fix proposals to budget import (#7449)
  Fix cost display on proposals (#7450)
  Fix #7487 - Invalid signature on message decryption (#7488)
  New Crowdin updates (#7482)
  Move specs file to correct folder (#7476)
  Improve changelog generator (#7475)
  New Crowdin updates (#7472)
  Prepare 0.25-dev version (#7473)
  New Crowdin updates (#7470)
  New Crowdin updates (#7468)
  Feature proposal infinite edit time (#7406)
  New Crowdin updates (#7457)
  Trigger docs build on folder changes (#7360)
  Add changelog generator based on PR data (#7461)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  ...
verarojman added a commit to Platoniq/decidim that referenced this pull request Mar 5, 2021
verarojman pushed a commit to Platoniq/decidim that referenced this pull request Mar 5, 2021
verarojman added a commit to Platoniq/decidim that referenced this pull request Mar 9, 2021
This was referenced Mar 9, 2021
microstudi pushed a commit to Platoniq/decidim that referenced this pull request Apr 19, 2021
This was referenced Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants