Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't schedule CI jobs for locales PRs (#7534)" #7546

Merged
merged 1 commit into from Mar 5, 2021

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Mar 5, 2021

馃帺 What? Why?

This PR reverts #7534 as it's breaking the pipelines for PRs coming from forks.

馃搶 Related Issues

None

Testing

None.

@mrcasals mrcasals merged commit 0d69358 into develop Mar 5, 2021
@mrcasals mrcasals deleted the revert/7534 branch March 5, 2021 07:32
@oliverbarnes
Copy link
Contributor

How is it breaking? Would be good to have this documented here

@mrcasals
Copy link
Contributor Author

mrcasals commented Mar 5, 2021

For some reason it's not starting the CI jobs for PRs coming from forks. I guess it's due to the removal of the pull_request trigger.

At some point we could try reapplying the path, but also keeping the pull_request part:

on:
  push:
    branches:
      - develop
      - release/*
      - "*-stable"
  pull_request:

env:
  ...

@oliverbarnes
Copy link
Contributor

Ok, I see. Yeah, that makes sense. Completely missed that in my review, I only saw the branch changes

entantoencuanto added a commit that referenced this pull request Mar 5, 2021
* develop:
  Fix infinite loop when impersonated session time runs out (#7221)
  New Crowdin updates (#7543)
  Migrate Admin menus to Menu Registry Part 2 (#7382)
  Replace xls with xlsx (#7421)
  Use cache_key_with_version instead of cache version (#7532)
  Add support for ElectionGuard voting scheme (#7454)
  Fix record encryptor trying to decrypt empty strings (#7542)
  Revert "Don't schedule CI jobs for locales PRs (#7534)" (#7546)
  New Crowdin updates (#7540)
  New Crowdin updates (#7539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants