Fix process serializer to consider nil images #7607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
added
module: participatory processes
type: fix
|
This needs to be backported to 0.23 and 0.24. |
mrcasals
added a commit
that referenced
this pull request
Mar 16, 2021
mrcasals
added a commit
that referenced
this pull request
Mar 16, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
When trying to export a participatory process without one of the images (hero image or banner image), the process fails because the presenter assumes the images exist.
This PR makes the presenter take into consideration these cases, so the serializer doesn't fail.
馃搶 Related Issues
None
Testing
Create a process without one of the images and try to export it.
馃搵 Checklist
None.