Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make category in the API non-mandatory #7624

Merged
merged 1 commit into from Mar 17, 2021

Conversation

microstudi
Copy link
Contributor

🎩 What? Why?

Currently querying the api with something like this:

{
  component(id: 123) {
    { 
       ...on Proposal {
         proposals { 
            edges { 
              node { 
                id, 
                category { id }
             }
          } 
       }
    }
  }
}

Does not return proposals without categories.
As category is not mandatory the api should honor that.

πŸ“Œ Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Just try to fetch any proposal without category with a query with the category element.

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Please add screenshots of the changes you're proposing

β™₯️ Thank you!

@mrcasals mrcasals changed the title Make category in the api non-mandatory Make category in the API non-mandatory Mar 17, 2021
@mrcasals mrcasals added graphql-api Affects the GraphQL API module: core type: fix PRs that implement a fix for a bug and removed type: bug Issues that describe a bug labels Mar 17, 2021
@mrcasals mrcasals merged commit dbefa5a into decidim:develop Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql-api Affects the GraphQL API module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants