Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix announcement cell heading #7631

Merged
merged 1 commit into from Mar 23, 2021
Merged

Fix announcement cell heading #7631

merged 1 commit into from Mar 23, 2021

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Reviewing v0.24 with @carolromero we've noticed that there are some new big titles in announcement. The font is too big, so this PR fixes that.

πŸ“Œ Related Issues

Testing

Open any announcement.

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Before

image

After

image

β™₯️ Thank you!

@mrcasals mrcasals added module: core type: change PRs that implement a change for an existing feature labels Mar 17, 2021
@mrcasals mrcasals merged commit 9cbe389 into develop Mar 23, 2021
@mrcasals mrcasals deleted the fix/heading-announcements branch March 23, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core type: change PRs that implement a change for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants