Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom focus outlines/backgrounds from the comments elements #7656

Merged
merged 1 commit into from Mar 22, 2021

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Mar 21, 2021

🎩 What? Why?

The comments elements have custom outlines and backgrounds on focus which are causing accessibility violations when customizing the default primary/secondary colors.

I think it would be better to keep these consistent with the other button/link elements, so their color contrasts can be controller better in the instance itself. This outline color can be also controlled from the admin panel.

WCAG 2.1 AA / SC 1.4.3

📌 Related Issues

Testing

Go to see the comments component with at least one comment and not signed in (see screenshots)

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Before:
Comments focus outlines before the change

After:
Comments focus outlines after the change

@mrcasals mrcasals added module: comments type: feature PRs or issues that implement a new feature labels Mar 22, 2021
@mrcasals mrcasals merged commit c6bde98 into decidim:develop Mar 22, 2021
@ahukkanen ahukkanen deleted the fix/a11y-comments-focus-borders branch March 22, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: comments type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants