Remove custom focus outlines/backgrounds from the comments elements #7656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The comments elements have custom outlines and backgrounds on focus which are causing accessibility violations when customizing the default primary/secondary colors.
I think it would be better to keep these consistent with the other button/link elements, so their color contrasts can be controller better in the instance itself. This outline color can be also controlled from the admin panel.
WCAG 2.1 AA / SC 1.4.3
📌 Related Issues
Testing
Go to see the comments component with at least one comment and not signed in (see screenshots)
📋 Checklist
docs/
.📷 Screenshots
Before:
After: