Show all proposals in map #7660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
force-pushed
the
fix/all-proposals-in-map
branch
from
deb2e65
to
8136601
Compare
mrcasals
added a commit
that referenced
this pull request
Mar 23, 2021
mrcasals
added a commit
that referenced
this pull request
Mar 23, 2021
This was referenced Mar 23, 2021
mrcasals
added a commit
that referenced
this pull request
Mar 23, 2021
mrcasals
added a commit
that referenced
this pull request
Mar 23, 2021
mrcasals
added a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Currently, the proposals map only shows the proposals that appear in the first page. If you change the page or the filters, the map doesn't get updated.
@decidim/product asked to show all proposals in the map.
Before this PR, the map only showed the geocoded proposals in the first page:
After this PR, it shows all the geocoded proposals in the component:
(notice the counts; the second picture is gray because it's taken from my local machine and maps don't render there)
馃搶 Related Issues
Fixes #6896
Testing
Ensure CI is green.