Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map preview when there is no address #7673

Merged
merged 2 commits into from Mar 23, 2021
Merged

Fix map preview when there is no address #7673

merged 2 commits into from Mar 23, 2021

Conversation

armandfardeau
Copy link
Contributor

@armandfardeau armandfardeau commented Mar 22, 2021 •
edited

🎩 What? Why?

Fix map preview when there is no address

📌 Related Issues

Testing

  • Go to the proposal component settings in the admin panel.
  • Click on 'Geocoding enabled'.
  • Create a proposal without address from the frontend.
  • Go to the final step of the wizard.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@armandfardeau armandfardeau marked this pull request as ready for review March 22, 2021 19:18
@mrcasals mrcasals added module: proposals type: fix PRs that implement a fix for a bug labels Mar 23, 2021
@mrcasals mrcasals merged commit a4c00f7 into decidim:develop Mar 23, 2021
mrcasals pushed a commit that referenced this pull request Mar 24, 2021
@armandfardeau @mrcasals
Fix map preview when there is no address (#7673)
2da19e8
@mrcasals mrcasals mentioned this pull request Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees
No one assigned
Labels
module: proposals type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the proposal wizard the map is shown even if the proposal has no geolocation
2 participants
@armandfardeau @mrcasals