Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heading order on the home page #7710

Merged
merged 1 commit into from Mar 25, 2021
Merged

Fix heading order on the home page #7710

merged 1 commit into from Mar 25, 2021

Conversation

ahukkanen
Copy link
Contributor

🎩 What? Why?

Accessibility rules require the heading order to be logic. This fixes the heading order on the home page.

Testing

Test the webpage with the linked accessibility audit tool.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Mar 25, 2021
@mrcasals mrcasals merged commit 96732de into decidim:develop Mar 25, 2021
@ahukkanen ahukkanen deleted the fix/a11y-heading-order-on-homepage branch March 25, 2021 11:58
@ahukkanen ahukkanen mentioned this pull request Mar 26, 2021
Merged
36 tasks
entantoencuanto added a commit that referenced this pull request Mar 26, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
f69e5a4 
* develop: (64 commits)
  Fix report mailers when author is a meeting (#7683)
  New Crowdin updates (#7729)
  Fix form builder assuming proposals module availability (#7689)
  Fix a series of issues with proposal attachments in the public area (#7699)
  New Crowdin updates (#7711)
  Add accessibility labels to the <nav> menus (#7709)
  Fix heading order on the home page (#7710)
  Fix dropdown menu accessibility audits (#7708)
  Fix the aria attribute names (no aria prefix) (#7707)
  Fix validations for registration related fields in Conference form (#7675)
  New Crowdin updates (#7613)
  Use comments counter cache instead of additional query (#7627)
  Upgrade to decidim-bulletin_board 0.15.2 (#7659)
  Bump mimemagic to 0.3.6 (#7701)
  Ensure pagination elements per page is a valid option (#7680)
  Fix link to "Getting started guide" in README.adoc (#7695)
  Fix link to CONTRIBUTING.adoc in PR template (#7696)
  Fix the screen reader class name for comments opinion toggle (#7698)
  Fix initiative-m card hashtags (#7679)
  Don't run all jobs on every PR (#7693)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees
No one assigned
Labels
module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahukkanen @mrcasals