Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the opacity from process upcoming/past/all filters for accessible contrast #7749

Merged

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Mar 25, 2021

🎩 What? Why?

The color contrast between the body background and the time filters for proposals is not sufficient.

This removes the opacity to make the contrast ratio sufficient.

The background color is #fafafa and the foreground color is #b6b2b5 (= #726a70 with 50% opacity against the background).

📌 Related Issues

Testing

  1. Go to: https://webaim.org/resources/contrastchecker/
  2. Add the old foreground color (#b6b2b5) as the foreground color
  3. Add the body background color (#fafafa) as the background color
  4. See the contrast ratio
  5. Repeat the test with the updated foreground color (#726a70)

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Before:
Process filters before the change

After:
Process filters after the change

@mrcasals mrcasals added the type: fix PRs that implement a fix for a bug label Mar 26, 2021
@mrcasals mrcasals merged commit 85ea114 into decidim:develop Mar 26, 2021
@ahukkanen ahukkanen deleted the fix/a11y-order-by-tabs-color-contrast branch March 26, 2021 13:30
entantoencuanto added a commit that referenced this pull request Mar 31, 2021
* develop: (26 commits)
  Fix trustees admin menu (#7772)
  Do not modify the controller class in the controller tests that render views (#7755)
  Add HTML escaping to the expectations as the strings are escaped (#7760)
  Add automated accessibility audit + HTML validation to CI pipeline (#7751)
  fix(elections): js assets manifest (#7759)
  Add admin missing translations (#7702)
  Add Conferences and Admin missing translations (#7653)
  New Crowdin updates (#7735)
  Improve vote flow (#7682)
  Strip the <p> tags from inside the heading elements (#7732)
  Fix the date cell spec failing randomly close to day changes (#7703)
  Change the timeline date color for accessible color contrast against its background (#7750)
  Remove the opacity from process upcoming/past/all filters for accessible contrast (#7749)
  Fix color contrast against the sidebar navigation background (#7748)
  Validate the HTML for the account page (#7747)
  Fix report modal form accessibility (#7746)
  Accessibility fixes for conversations (#7745)
  Add a landmark ARIA role to the cookie banner (#7738)
  Fix HTML validation on standalone content page (#7744)
  Add aria-label to the area filter on participatory space pages (#7743)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants