Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proposal form attachment errors #7856

Merged
merged 3 commits into from Apr 19, 2021
Merged

Fix proposal form attachment errors #7856

merged 3 commits into from Apr 19, 2021

Conversation

lahdeero
Copy link
Contributor

🎩 What? Why?

When creating new proposal: the file fields do not display an error, they should show "needs to be reattached".

Testing

Inside a proposals component with attachments and card images enabled:

  1. Create a new proposal
  2. Write the title with the first letter being in lowercase
  3. Add both image and attachment files to the proposal
  4. Submit the form
  5. See an error

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

needs_to_be_reattached

♥️ Thank you!

@mrcasals mrcasals added module: proposals type: fix PRs that implement a fix for a bug labels Apr 19, 2021
@mrcasals mrcasals merged commit 9bb5ef2 into decidim:develop Apr 19, 2021
@ahukkanen ahukkanen deleted the fix/proposal_form_attachment_errors branch April 19, 2021 12:22
entantoencuanto added a commit that referenced this pull request Apr 19, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
34a28b7 
* develop:
  New Crowdin updates (#7850)
  Accessibility tool for development environments (#7810)
  Attempt to fix puffing-billy runtime error (#7853)
  Dynamically get all participatory space role tables for the `visible_meeting_for` query (#7855)
  Fix joining a meetings that the user already follows (#7854)
  Improve proposals import options (#7669)
  Fix proposal form attachment errors (#7856)
  New Crowdin updates (#7844)
  Fix branch name on generators (#7849)
  Conditionally render questions in election booth (#7822)
  Fix node version for version managers (#7848)
  Migrate to Webpacker (#7464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees
No one assigned
Labels
module: proposals type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lahdeero @mrcasals