Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade decidim-bulletin_board to 0.20.0 #7881

Merged
merged 3 commits into from Apr 22, 2021

Conversation

beagleknight
Copy link
Contributor

🎩 What? Why?

This PR upgrades Bulletin Board dependencies to the latest version (0.20.0). This version includes some breaking changes that have been addressed in this pull request.

I also added the prettier plugin for eslint so formatting doesn't affect linting rules 👍

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

orlera
orlera previously approved these changes Apr 22, 2021
slickepinne
slickepinne previously approved these changes Apr 22, 2021
Copy link
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

const electionUniqueId = `${$keyCeremony.data("authoritySlug")}.${$keyCeremony.data("electionId")}`
const authorityPublicKeyJSON = JSON.stringify($keyCeremony.data("authorityPublicKey"))
};
const electionUniqueId = `${$keyCeremony.data(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a personal opinion but I think the formatted syntax is harder to read. 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I agree! Prettier is weird sometimes haha

@beagleknight beagleknight dismissed stale reviews from slickepinne and orlera via f760bb4 April 22, 2021 11:26
@beagleknight
Copy link
Contributor Author

@decidim/mantainers I just realized that we don't have a package-lock.json and we are using yarn.lock so I'm changing all references from npm to yarn. At some point we can discuss if we use one package manager or the other 👍

leio10
leio10 previously approved these changes Apr 22, 2021
Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

.github/workflows/ci_elections_system_admin.yml Outdated Show resolved Hide resolved
@beagleknight
Copy link
Contributor Author

@decidim/mantainers Ready to be reviewed! 😄

@mrcasals mrcasals merged commit d19056e into develop Apr 22, 2021
@mrcasals mrcasals deleted the chore/upgrade-decidim-bulletin-board-to-0.20.0 branch April 22, 2021 14:02
entantoencuanto added a commit that referenced this pull request Apr 23, 2021
* develop:
  Upgrade decidim-bulletin_board to 0.20.0 (#7881)
  New Crowdin updates (#7870)
  Fix editor: shift+enter makes single br tag before link (#7877)
  Fix TypeError in newsletters (#7872)
  Give admin panel access to monitoring committee members (#7843)
  New Crowdin updates (#7869)
  New Crowdin updates (#7864)
  Onboarding workflow after voting (#7839)
  Fix filter by scopes (#7858)
  Redirect unauthenticated users to sign in page for unauthorized views (#7852)
  New Crowdin updates (#7861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants