New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend CSS overwritting #8007
Amend CSS overwritting #8007
Conversation
decidim-core/app/packs/stylesheets/decidim/decidim_application.scss
Outdated
Show resolved
Hide resolved
copy_file "decidim_application.scss", "app/packs/stylesheets/decidim/decidim_application.scss" | ||
copy_file "_decidim-settings.scss", "app/packs/stylesheets/decidim/_decidim-settings.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should copy this file to the application by default.
I would be personally fine with that (since it's needed in all cases for us) but the current core does not automatically copy this file, which is why I wonder if it should be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I was copying it for simplicity for developers to start overriding vars (I think most of the Rails apps use this feature to change colors). What do you think @mrcasals ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* develop: (59 commits) Update supported versions in docs (#8079) Meetings merge minutes and close actions (#7968) Meeting calendars providers (#7944) Fix broken test on meetings after merging PR without rebase (#8076) Show participants list in meetings (#7933) Security feature external link warning (#7397) Add missing tests for scope types admin page (#8053) Use symbols for polymorphic route arguments (#8052) Mockup design for Participation statistics tables in Votings (#7879) Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990) Fix redirects broken by Terms and Conditions redirect (#8036) Amend CSS overwritting (#8007) New Crowdin updates (#8048) Fix undetected broken tests because of missing dependencies (#8050) Validate results by Monitoring Committee Members (#7899) Electoral certificate validation by Monitoring Committee Members (#7871) Publish and unpublish a meeting (#7893) New Crowdin updates (#8005) Polling station closure attach the physical electoral closure certificate (#7929) Fix attachment title migration generating possibly invalid values (#8020) ...
🎩 What? Why?
This PR improves how CSS are overwritten:
📌 Related Issues
Testing
Create a new development_app with no CSS overrides.
Three scenarios:
You should see the body has changed in the whole app
You should paragraphs in red
cp decidim-core/app/packs/stylesheets/decidim/layouts/_home.scss development_app/app/packs/stylesheets/decidim/layouts/
. Then edit the overriden file and change some styles, you should see those styles in the app📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots
Please add screenshots of the changes you're proposing