Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status search on projects page #8204

Merged
merged 3 commits into from Jul 19, 2021
Merged

Fix status search on projects page #8204

merged 3 commits into from Jul 19, 2021

Conversation

leio10
Copy link
Contributor

@leio10 leio10 commented Jul 15, 2021

🎩 What? Why?

The projects search by status is not working. It stopped working after #6438 and there were no tests for that. This PR fixes this issue and adds the missing tests.

πŸ“Œ Related Issues

Testing

  1. Create a budgets component, with a budget item and some projects.
  2. Mark some projects as selected and configure the active participatory step as "Voting finished".
  3. Go to the budget page and filter projects by status.

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Please add screenshots of the changes you're proposing
Description

β™₯️ Thank you!

@leio10 leio10 self-assigned this Jul 15, 2021
@leio10 leio10 added module: budgets type: fix PRs that implement a fix for a bug labels Jul 15, 2021
oriolgual
oriolgual previously approved these changes Jul 16, 2021
@leio10 leio10 marked this pull request as ready for review July 16, 2021 15:08
@leio10 leio10 merged commit 087fad5 into develop Jul 19, 2021
@leio10 leio10 deleted the fix/projects-search branch July 19, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review module: budgets type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants