Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix statistics in Comments (#8012) #8316

Merged
merged 1 commit into from Sep 9, 2021

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport of #8012 to the 0.25-stable

  • Wrong Statistics Metrics being computed
  • Add polymorphism for Participatory space
  • Adding latest suggestions

πŸ“Œ Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Please add screenshots of the changes you're proposing
Description

β™₯️ Thank you!

* Wrong Statistics Metrics being computed

* Add polymorphism for Participatory space

* Adding latest suggestions
@alecslupu alecslupu changed the title Fix statistics in Comments (#8012) Backport: Fix statistics in Comments (#8012) Sep 8, 2021
@leio10 leio10 added backport Pull Requests that are a backport for a fixed bug in-review module: comments type: fix PRs that implement a fix for a bug labels Sep 9, 2021
@leio10 leio10 merged commit 956620a into decidim:release/0.25-stable Sep 9, 2021
@alecslupu alecslupu deleted the backport/8012 branch September 10, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug in-review module: comments type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants