Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Disallow redirection to the host when performing redirect_back #8402

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

roxanaopr
Copy link
Contributor

@roxanaopr roxanaopr commented Oct 13, 2021

Co-authored-by: Alexandru-Emil Lupu contact@alecslupu.ro

🎩 What? Why?

Backports the fix from #8296 to 0.25.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

…im#8296)

Co-authored-by: Alexandru-Emil Lupu <contact@alecslupu.ro>
@roxanaopr roxanaopr changed the title Disallow redirection to the host when performing redirect_back (#8296) Backport: Disallow redirection to the host when performing redirect_back (#8296) Oct 13, 2021
@leio10 leio10 added type: enhancement module: core team: security backport Pull Requests that are a backport for a fixed bug in-review labels Oct 14, 2021
@andreslucena andreslucena changed the title Backport: Disallow redirection to the host when performing redirect_back (#8296) Backport: Disallow redirection to the host when performing redirect_back Oct 15, 2021
@leio10
Copy link
Contributor

leio10 commented Oct 25, 2021

@roxanaopr can you rebase or merge with the lasts commits on the branch to fix the broken test?

@leio10 leio10 merged commit 9d98e62 into decidim:release/0.25-stable Oct 26, 2021
@andreslucena andreslucena added type: feature PRs or issues that implement a new feature and removed type: enhancement labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug in-review module: core team: security type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants