Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fixing generator webpacker issues" #8438

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Oct 25, 2021

🎩 What? Why?

Backport of Fixing generator webpacker issues #8427 to 0.25-stable

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu added the backport Pull Requests that are a backport for a fixed bug label Oct 25, 2021
@alecslupu alecslupu requested a review from leio10 October 25, 2021 15:10
@leio10 leio10 changed the base branch from develop to release/0.25-stable October 26, 2021 08:11
@andreslucena andreslucena changed the title [Backport 8427] Fixing generator webpacker issues Backport "Fixing generator webpacker issues" Oct 26, 2021
leio10
leio10 previously approved these changes Oct 26, 2021
@leio10
Copy link
Contributor

leio10 commented Oct 26, 2021

@alecslupu the tests were not executed (probably because the base branch was wrong). Can you force the checks to be run? You can do it updating the commit message, merging the last branch changes or adding an empty commit. Thanks!

@leio10 leio10 merged commit 7d6698d into decidim:release/0.25-stable Oct 26, 2021
@alecslupu alecslupu deleted the backport/8427 branch October 26, 2021 11:22
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: generators type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants