New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group mentions in notifications #8598
Conversation
@decidim/product This feature is ready and uploaded in staging. |
While reviewing this issue, I found a couple of things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of suggestions and one general comment, can you check it please @quinHD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ππ½
π© What? Why?
This PR display fix the group mention in notifications. It's deeply explained in the issue #8485 .
π Related Issues
Link your PR to an issue
Testing
Acceptance criteria
When I go to my notifications page
Then I can see which group I was mentioned.
Step by Step
You need a user_group_mentioned notification. First of all, you have to belong to a group. To do that, log in with an alternative user and go to /profiles/<user_nickname>/groups. There, go to a group you administrate and invite your original user.
Then, log in with your original user an accept the group invitation from that you'll find in /profiles/<user_nickname>/groups.
Once you belong to a group, you are ready to receive the notification.
From the alternative user, create a comment in a proposal, in that comment, you have to mention the group the original user belongs to.
After that, go to /notifications with the original user logged and there, you''ll see a notification with the group mentioned.
Screenshots
π Checklist
π¨ Please review the guidelines for contributing to this repository.
docs/
.π· Screenshots
Please add screenshots of the changes you're proposing
Staging: