Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importmap rails #8745

Closed
wants to merge 68 commits into from
Closed

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Please describe your pull request.

πŸ“Œ Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Please add screenshots of the changes you're proposing
Description

β™₯️ Thank you!

@alecslupu alecslupu force-pushed the importmap-rails branch 4 times, most recently from 7a859f0 to 8ee0c63 Compare February 6, 2022 17:05
@alecslupu
Copy link
Contributor Author

alecslupu commented Feb 7, 2022

Findings after 100+ files being changed....

  1. ImportMaps may be useful for SPA
  2. ImportMaps works fine only with Support from Sprockets

Please see : #8783 (comment)

@alecslupu alecslupu force-pushed the importmap-rails branch 3 times, most recently from 321df91 to 08d4de9 Compare February 13, 2022 08:01
@alecslupu alecslupu mentioned this pull request Mar 9, 2022
12 tasks
@alecslupu
Copy link
Contributor Author

At the moment there is no point in continuing work on this PR due to lack of support adopting this functionality.

@alecslupu alecslupu closed this Apr 20, 2022
@justin808
Copy link

@alecslupu what major issues did you face with https://github.com/rails/importmap-rails?

@alecslupu
Copy link
Contributor Author

@alecslupu what major issues did you face with https://github.com/rails/importmap-rails?

@justin808, This is just a decidim related thing. In our case:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants