New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing proposal tests #8970
Merged
andreslucena
merged 10 commits into
decidim:develop
from
mainio:fix/edit_proposals_flaky_test
Mar 8, 2022
Merged
Fix failing proposal tests #8970
andreslucena
merged 10 commits into
decidim:develop
from
mainio:fix/edit_proposals_flaky_test
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahdeero
changed the title
Check hidden selectors before submitting form
Fix failing edit proposal test
Mar 4, 2022
andreslucena
added
flaky spec
module: core
module: proposals
type: internal
PRs that aren't necessary to add to the CHANGELOG for implementers
labels
Mar 7, 2022
Seems like the last change did the trick @lahdeero, thank you and congratulations on finding it! I'm relaunching the specs for these a couple of times just to be sure before merging. Should we leave the rest of changes, or just this last one? |
@andreslucena I did some cleaning, these changes should be enough 馃檹 |
andreslucena
approved these changes
Mar 7, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky spec
module: core
module: proposals
type: internal
PRs that aren't necessary to add to the CHANGELOG for implementers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
I think some tests related to dynamic attachment uploads failed because when there were multiple uploads in same test. This was probably happening because after first successfully upload there was "progress-bar.filled" although the new upload was not ready yet. Here we check that the "progress-bar" is filled for the file currently being uploaded.
馃搶 Related Issues
#8681
Testing
Trying to run tests in CI multiple times.
Locally everything seems fine: