Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing proposal tests #8970

Merged
merged 10 commits into from Mar 8, 2022

Conversation

lahdeero
Copy link
Contributor

@lahdeero lahdeero commented Mar 4, 2022

馃帺 What? Why?

I think some tests related to dynamic attachment uploads failed because when there were multiple uploads in same test. This was probably happening because after first successfully upload there was "progress-bar.filled" although the new upload was not ready yet. Here we check that the "progress-bar" is filled for the file currently being uploaded.

馃搶 Related Issues

#8681

Testing

Trying to run tests in CI multiple times.

Locally everything seems fine:

cd decidim-proposals
bundle exec rspec spec/system/edit_proposal_spec.rb -e "can add many images many times"
bundle exec rspec spec/system/proposals_fields_spec.rb -e "sets the card image correctly with zero weight"

鈾ワ笍 Thank you!

@lahdeero lahdeero changed the title Check hidden selectors before submitting form Fix failing edit proposal test Mar 4, 2022
@lahdeero lahdeero changed the title Fix failing edit proposal test Fix failing proposal tests Mar 4, 2022
@andreslucena andreslucena added flaky spec module: core module: proposals type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Mar 7, 2022
@andreslucena
Copy link
Member

Seems like the last change did the trick @lahdeero, thank you and congratulations on finding it!

I'm relaunching the specs for these a couple of times just to be sure before merging.

Should we leave the rest of changes, or just this last one?

@lahdeero
Copy link
Contributor Author

lahdeero commented Mar 7, 2022

@andreslucena I did some cleaning, these changes should be enough 馃檹

@andreslucena andreslucena mentioned this pull request Mar 8, 2022
12 tasks
@andreslucena andreslucena merged commit 0abaa16 into decidim:develop Mar 8, 2022
@lahdeero lahdeero deleted the fix/edit_proposals_flaky_test branch March 8, 2022 09:00
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky spec module: core module: proposals type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants