Fix flaky factory when the user's sequence name arrives to 1234

[andreslucena]

🎩 What? Why?

On #9164 it was detected a flaky spec that comes from a seed related to #9090.

The culprit is the sequence name, when it arrives to 1234 and the password validation kicks in.

This PR fixes it by removing this sequence in the name.

📌 Related Issues

• Related to Enforce password validation rules on 'Forgot your password?' form #9090

Testing

To test the failing, you can do it with this script:

require "faker"
require "factory_bot"
require "decidim/core/test/factories"

FactoryBot.define do
  factory :user2, class: "Decidim::User" do
    email { "user#{rand(100..10000)}@example.org" } # Changed to skip email already taken validation
    password { "decidim123456" }
    password_confirmation { password }
    name { "#{Faker::Name.name} 1234".delete("'") } # Here's the problem if n arrives to 1234
    nickname { generate(:nickname) }
    organization { Decidim::Organization.first } # Changed to skip organization already taken validation
    tos_agreement { "1" }
  end 
end

FactoryBot.create :user2

♥️ Thank you!

[ahukkanen]

LGTM!

I cannot think of a situation where the name would have to be unique. In real life we can also have people with exactly the same names.

I also checked that generate(:name) is used only for these:

• User names
• Dummy resource titles
• Nested dummy resource titles
• Coauthorable dummy resource titles
• In a migratiion spec testing the blocked user name migration

So this seems fine!