Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix budget amounts in project seeds #9174

Merged
merged 1 commit into from Apr 29, 2022

Conversation

lahdeero
Copy link
Contributor

@lahdeero lahdeero commented Apr 20, 2022

馃帺 What? Why?

Seeds can be so annoying currently: They don't include votes (budget orders) and when user wants to create vote, it might be impossible because every project can have budget amount higher than total budget or project has budget amount less than default "vote threshold percent" which is 70%.

Testing

  1. Create development app
  2. Sign in
  3. Go to budgets component and vote in some budget

馃摲 Screenshots

image

鈾ワ笍 Thank you!

@lahdeero lahdeero changed the title Project budget amount is less than total budget Fix budget amounts in budget seeds Apr 20, 2022
@lahdeero lahdeero changed the title Fix budget amounts in budget seeds Fix budget amounts in project seeds Apr 20, 2022
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I've just checked it locally and it works as expected. This is the typical tiny stuff that I had in my mental backlog to fix 馃槃

Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! And finally! 馃コ 馃帀

@ahukkanen ahukkanen merged commit 0482d2e into decidim:develop Apr 29, 2022
@ahukkanen ahukkanen deleted the fix/budget_seeds branch April 29, 2022 13:50
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants