Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light refactor for fetching admins #9287

Merged
merged 2 commits into from May 13, 2022
Merged

Light refactor for fetching admins #9287

merged 2 commits into from May 13, 2022

Conversation

Quentinchampenois
Copy link
Contributor

🎩 What? Why?

I found duplicated methods for fetching administrators. This PR only contains a light refactor but doesn't change the current behaviour.
Also, there is no specific performances gain.

📌 Related Issues

No issues defined since it is just a simple suggestion.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@Quentinchampenois Quentinchampenois marked this pull request as ready for review May 11, 2022 12:03
@ahukkanen ahukkanen added target: developer-experience type: internal PRs that aren't necessary to add to the CHANGELOG for implementers module: verifications module: initiatives labels May 13, 2022
@ahukkanen ahukkanen merged commit 14b3cdb into decidim:develop May 13, 2022
andreslucena pushed a commit that referenced this pull request May 19, 2022
@Quentinchampenois @andreslucena
Light refactor for fetching admins (#9287)
98e589c 
* Remove duplicated 'organization_admins' method

* Replace ActiveRecord query by 'admins' relation from organization model
andreslucena pushed a commit that referenced this pull request May 19, 2022
@Quentinchampenois @andreslucena
Light refactor for fetching admins (#9287)
7650b3b 
* Remove duplicated 'organization_admins' method

* Replace ActiveRecord query by 'admins' relation from organization model
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
@Quentinchampenois @eliegaboriau
Light refactor for fetching admins (decidim#9287)
783a2f2 
* Remove duplicated 'organization_admins' method

* Replace ActiveRecord query by 'admins' relation from organization model
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
module: initiatives module: verifications target: developer-experience type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quentinchampenois @ahukkanen @alecslupu