Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rubocop violations and normalize locales #9305

Merged
merged 2 commits into from May 16, 2022
Merged

Fix Rubocop violations and normalize locales #9305

merged 2 commits into from May 16, 2022

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented May 13, 2022 •
edited

🎩 What? Why?

There were few PRs that caused some issues with the CI after merged to develop.

This fixes those issues.

📌 Related Issues

Testing

See that CI is green (or run the related specs).

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen ahukkanen added module: meetings module: budgets type: internal PRs that aren't necessary to add to the CHANGELOG for implementers type: fix PRs that implement a fix for a bug labels May 13, 2022
@ahukkanen ahukkanen requested a review from microstudi May 13, 2022 18:37
@ahukkanen ahukkanen removed the type: fix PRs that implement a fix for a bug label May 13, 2022
andreslucena
andreslucena approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreslucena andreslucena merged commit 2819b44 into decidim:develop May 16, 2022
This was referenced May 16, 2022
Closed
Closed
@ahukkanen ahukkanen deleted the fix/ci branch May 16, 2022 07:59
andreslucena pushed a commit that referenced this pull request May 19, 2022
@ahukkanen @andreslucena
Fix Rubocop violations and normalize locales (#9305)
2fc0584 
* Normalize locales

* Fix Rubocop violations in budgets permissions
andreslucena pushed a commit that referenced this pull request May 19, 2022
@ahukkanen @andreslucena
Fix Rubocop violations and normalize locales (#9305)
4129b95 
* Normalize locales

* Fix Rubocop violations in budgets permissions
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
@ahukkanen @eliegaboriau
Fix Rubocop violations and normalize locales (decidim#9305)
bbd3aee 
* Normalize locales

* Fix Rubocop violations in budgets permissions
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

@microstudi microstudi Awaiting requested review from microstudi

Assignees
No one assigned
Labels
module: budgets module: meetings type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahukkanen @andreslucena @alecslupu